-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingest: reduce memory consumption of CheckpointChangeReader #5270
Merged
tamirms
merged 9 commits into
stellar:master
from
tamirms:improve-checkpoint-change-reader
Apr 15, 2024
Merged
ingest: reduce memory consumption of CheckpointChangeReader #5270
tamirms
merged 9 commits into
stellar:master
from
tamirms:improve-checkpoint-change-reader
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
force-pushed
the
improve-checkpoint-change-reader
branch
from
April 1, 2024 11:14
2c73cf6
to
ba2a0bc
Compare
sreuland
reviewed
Apr 15, 2024
sreuland
reviewed
Apr 15, 2024
sreuland
reviewed
Apr 15, 2024
sreuland
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left comment for consideration in adding test coverage if possible
Shaptic
reviewed
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Reduce memory consumption by about 1GB when iterating through ledger entries during state verification and state rebuilds. This reduction in memory is achieved by:
map[string]struct{}
to store ledger keys instead ofmap[string]bool{}
(see https://stackoverflow.com/questions/57620170/can-you-have-a-map-with-no-value-in-go )The first optimization takes advantage of the fact that claimable balance and offer ids are globally unique. Once a claimable balance or offer is deleted it is impossible to restore it or create a new claimable balance / offer with the same id.
Known limitations
[N/A]